Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: when selecting categories, the selected categories get reset" #54583

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Revert "fix: when selecting categories, the selected categories get reset" #54583

merged 1 commit into from
Dec 26, 2024

Conversation

neil-marcellini
Copy link
Contributor

Explanation of change

Reverts #53519 to fix #54486. The PR we're reverting uncovered that issue. There's probably a better way to fix the original issue that PR aimed to solve, without causing this bug.

Fixed Issues

$ #54486

@neil-marcellini neil-marcellini self-assigned this Dec 26, 2024
@neil-marcellini neil-marcellini requested a review from a team as a code owner December 26, 2024 17:45
@neil-marcellini neil-marcellini requested review from jasperhuangg and removed request for a team December 26, 2024 17:45
@melvin-bot melvin-bot bot requested a review from MarioExpensify December 26, 2024 17:45
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 26, 2024

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini neil-marcellini merged commit 56e35ce into main Dec 26, 2024
13 of 16 checks passed
@neil-marcellini neil-marcellini deleted the revert-53519-fix-49322 branch December 26, 2024 17:47
@melvin-bot melvin-bot bot added the Emergency label Dec 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 26, 2024

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@neil-marcellini
Copy link
Contributor Author

Straight revert so no need for checklists

OSBotify pushed a commit that referenced this pull request Dec 26, 2024
@neil-marcellini @OSBotify
Merge pull request #54583 from Expensify/revert-53519-fix-49322
0356239 
Revert "fix: when selecting categories, the selected categories get reset"

(cherry picked from commit 56e35ce)

(CP triggered by AndrewGable)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 26, 2024
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.78-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@truph01 truph01 mentioned this pull request Dec 30, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

@MarioExpensify MarioExpensify Awaiting requested review from MarioExpensify

Assignees

@neil-marcellini neil-marcellini

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Category - Selected item is no longer selected after renaming the category
3 participants
@neil-marcellini @OSBotify @jasperhuangg